[Webkit-unassigned] [Bug 69920] [Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69920





--- Comment #5 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2011-10-13 04:04:47 PST ---
(In reply to comment #4)
> (From update of attachment 110675 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110675&action=review
> 
> > Source/WebKit.pri:-112
> > -symbian|*-armcc {
> > -    # Enable GNU compiler extensions to the ARM compiler for all Qt ports using RVCT
> > -    RVCT_COMMON_CFLAGS = --gnu --diag_suppress 68,111,177,368,830,1293
> > -    RVCT_COMMON_CXXFLAGS = $$RVCT_COMMON_CFLAGS --no_parse_templates
> > -    # Make debug symbols leaner in RVCT4.x. Ignored by compiler for release builds
> > -    QMAKE_CXXFLAGS.ARMCC_4_0 += --remove_unneeded_entities
> > -    # Match other compilers' (GCC, MSVC, WINSCW...) behavior regarding bitfield signedness.
> > -    # This flag is not needed for RVCT 2.x.
> > -    QMAKE_CXXFLAGS.ARMCC_4_0 += --signed_bitfields
> > -}
> > -
> > -*-armcc {
> > -    QMAKE_CFLAGS += $$RVCT_COMMON_CFLAGS
> > -    QMAKE_CXXFLAGS += $$RVCT_COMMON_CXXFLAGS
> > -}
> 
> Yeah I wonder about these as well.

These are indeed not (just) symbian specific. In theory these are for any QtWebKit port/project using RVCT, but to my knowledge the only port/project using RVCT is the Symbian port so I deliberately removed it. We surely do not have a buildbot using RVCT other than Symbian.

COMPILER(RVCT) code sections are not removed as those are indeed shared with other non-Qt based ports, but the changes in the Qt make file are for the Qt port only.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.