[Webkit-unassigned] [Bug 61344] --webkit-visual-word does not work in multi-line

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 14:56:28 PDT 2011


--- Comment #36 from Xiaomei Ji <xji at chromium.org>  2011-10-12 14:56:28 PST ---
(From update of attachment 110748)
View in context: https://bugs.webkit.org/attachment.cgi?id=110748&action=review

>> Source/WebCore/editing/visible_units.cpp:606
>> +    }
> Why do we need this struct? Can't we just pass arguments around?

yes you are right that we do not need this struct. instead, we can just pass arguments around. then, instead of a struct, we will need to pass 4 arguments around. Also, the |offset| and |root| are only needed if the |rule| is CanNotCrossEditingBoundary.

>> Source/WebCore/editing/visible_units.cpp:629
>> +    RootInlineBox*& rootInlineBox, Position& candidatePos) {
> Maybe this needs to moved to RenderedPosition.

what is the rule-of-thumb here?

>> Source/WebCore/editing/visible_units.cpp:1523
>> +static const RootInlineBox* previousRootInlineBox(const InlineBox* box)
> Why is this function different from nextRootInlineBoxOrCandidatePos? These two functions should be symmetric to each other.

Yes, you are right. I have not make that change yet. would like to check with you that this is in the right track first.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list