[Webkit-unassigned] [Bug 69850] Enable out-of-thread compositing in WebKit compositor API

Wed Oct 12 14:54:51 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=69850

James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110536|review?                     |review+
               Flag|                            |

--- Comment #8 from James Robinson <jamesr at chromium.org>  2011-10-12 14:54:51 PST ---
(From update of attachment 110536)
R=me but there's still something a bit amiss here.  Right now there are 2 ways to indicate threading support via the WK API - you can set the appropriate CCSettings value and call WebCompositor::setThread(). If you do the former but not the latter you hit ASSERT()s and crash today.  I think we want to just make the latter be the control - if you pass a thread to WebCompositor::setThread() then the compositor uses it, otherwise it runs single-threaded.

Does that sound like a good plan going forward, Nat?  To be clear I think this patch is fine to land - we can clean things up later.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.