[Webkit-unassigned] [Bug 61344] --webkit-visual-word does not work in multi-line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61344





--- Comment #34 from Ryosuke Niwa <rniwa at webkit.org>  2011-10-12 14:50:36 PST ---
(From update of attachment 110748)
View in context: https://bugs.webkit.org/attachment.cgi?id=110748&action=review

> Source/WebCore/editing/visible_units.cpp:606
> +struct RootInlineBoxAndPositionInfo {
> +    RootInlineBoxAndPositionInfo(EditingBoundaryCrossingRule rule, int offset, Node* root, bool returnPos)
> +        : rule(rule)
> +        , offset(offset)
> +        , highestRoot(root)
> +        , returnCandidatePosition(returnPos)
> +    {
> +    }

Why do we need this struct? Can't we just pass arguments around?

> Source/WebCore/editing/visible_units.cpp:629
> +static void nextRootInlineBoxOrCandidatePos(Node* node, const RootInlineBoxAndPositionInfo& info,
> +    RootInlineBox*& rootInlineBox, Position& candidatePos) {

Maybe this needs to moved to RenderedPosition.

> Source/WebCore/editing/visible_units.cpp:694
> +                                          highestEditableRoot(p), true);

Nit: wrong indentation.

> Source/WebCore/editing/visible_units.cpp:1523
> +static const RootInlineBox* previousRootInlineBox(const InlineBox* box)

Why is this function different from nextRootInlineBoxOrCandidatePos? These two functions should be symmetric to each other.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.