[Webkit-unassigned] [Bug 69962] Make it possible to create and dispatch a message event through chromium API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 14:32:53 PDT 2011


--- Comment #4 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-10-12 14:32:53 PST ---
(From update of attachment 110742)
View in context: https://bugs.webkit.org/attachment.cgi?id=110742&action=review

API changes LGTM modulo the nit.

> Source/WebKit/chromium/public/WebDOMMessageEvent.h:48
> +    WEBKIT_EXPORT void initMessageEvent(const WebString& type, bool canBubble, bool cancelable, const WebSerializedScriptValue& message_data, const WebString& origin, const WebFrame& sourceFrame, const WebString& lastEventId, const WebMessagePortChannelArray& webChannels);

nit: message_data -> messageData

> Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp:239
> +    return m_localPort && m_localPort->hasPendingActivity();

I'm not super familiar with this code.  It would be good to get someone
like levin at chromium.org to look over this patch too.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list