[Webkit-unassigned] [Bug 69028] Add getSubstringFromRange() and selectionRange() for chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69028





--- Comment #9 from Peng Huang <penghuang at chromium.org>  2011-10-12 10:48:43 PST ---
(From update of attachment 110547)
View in context: https://bugs.webkit.org/attachment.cgi?id=110547&action=review

>> Source/WebKit/chromium/public/WebWidget.h:154
>> +    virtual WebString getSubstringFromRange(size_t location, size_t length) const { return WebString(); }
> 
> shouldn't this just be a method on WebRange?  it seems like we should be using WebRange
> for more of these range related APIs.  we should also be providing ways to get a WebRange
> or construct a WebRange.

Did you mean add a function `WebRange WebView::getRange(size_t location, size_t length)' here?
Or add a constructor WebRange::WebRange(WebFrame *frame, size_t location, size_t length).

For adding WebRange::WebRange, WebRange can not get enough information from WebFrame for creating a new WebRange. I think we need a function to convert WebFrame back to WebCore::Frame. Is it OK? What's you suggestion?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.