[Webkit-unassigned] [Bug 68464] Update MediaStream to use WebCore platform interfaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68464





--- Comment #2 from Adam Barth <abarth at webkit.org>  2011-10-12 10:23:24 PST ---
(From update of attachment 110604)
View in context: https://bugs.webkit.org/attachment.cgi?id=110604&action=review

This looks pretty good.  There's still the question of whether |context| should be first in constructors.  Also, almost all the places in this patch where we're using unsigned, we probably should be using size_t.

> Source/WebCore/dom/MediaStream.cpp:48
> +    MediaStreamTrackVector trackVector;
> +    unsigned numberOfTracks = m_descriptor->numberOfComponents();

You can call reserveCapacity on the vector if you know ahead of time how many items you're going to append.

> Source/WebCore/dom/MediaStreamTrack.cpp:50
> +    DEFINE_STATIC_LOCAL(AtomicString, kind, (m_streamDescriptor->component(m_trackIndex)->source()->type() == MediaStreamSource::TypeAudio ? "audio" : "video"));

It's strange to use a static local that's based on member variables...  This doesn't seem right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.