[Webkit-unassigned] [Bug 69097] REGRESSION (r95381): Standalone video can be focused and draws a focus ring

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 06:54:23 PDT 2011


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
 Attachment #110673|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #18 from Eric Carlson <eric.carlson at apple.com>  2011-10-12 06:54:22 PST ---
(From update of attachment 110673)
View in context: https://bugs.webkit.org/attachment.cgi?id=110673&action=review

This is really close, but I think it makes sense to correct the one mistake before committing.

> LayoutTests/fast/events/media-focus-in-standalone-media-document-expected.txt:11
> +*** Video element clicked.
> +
> +*** Should not focus video element by mouse click.
> +EXPECTED (standaloneMediaDocument.activeElement != '[object HTMLVideoElement]') OK

The results are confusing, it looks like the click event happens before the test...

> LayoutTests/fast/events/media-focus-in-standalone-media-document.html:43
> +                videoElement.dispatchEvent(click);
> +                consoleWrite("<br>*** Should not focus video element by mouse click.");
> +                testExpected("standaloneMediaDocument.activeElement", videoElement, "!=");

because you dispatch the event before you write the comment about what is being tested.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list