[Webkit-unassigned] [Bug 64865] Switch isQuirkValue() virtual function to inline one.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64865





--- Comment #14 from Antti Koivisto <koivisto at iki.fi>  2011-10-12 02:54:40 PST ---
(From update of attachment 101455)
View in context: https://bugs.webkit.org/attachment.cgi?id=101455&action=review

> Source/WebCore/css/CSSPrimitiveValue.h:27
> +#include <wtf/AlwaysInline.h>

Not needed.

> Source/WebCore/css/CSSPrimitiveValue.h:196
> -    virtual bool isQuirkValue() { return false; }
> +    ALWAYS_INLINE bool isQuirkValue() { return m_isQuirkValue; }

Remove ALWAYS_INLINE. This will almost surely inline without it.

> Source/WebCore/css/CSSPrimitiveValue.h:206
>  
> +    bool m_isQuirkValue;

Move this to this bitfield:

    signed m_type : 31;
    mutable unsigned m_hasCachedCSSText : 1;

Take one bit out from m_type. Make all member variables protected instead of private.

> Source/WebCore/css/CSSQuirkPrimitiveValue.h:44
>      {
> +        m_isQuirkValue = false;
>      }

Should be set to true here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.