[Webkit-unassigned] [Bug 68610] Microdata: Basic implementation of document.getItems() method

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68610





--- Comment #18 from Ryosuke Niwa <rniwa at webkit.org>  2011-10-12 00:51:48 PST ---
(In reply to comment #17)
> > Please modify invalidateCachesThatDependOnAttributes instead. m_classNodeListCache is a good one to mimic. r- because of this.
> 
> In case of class attribute when classAttr changes it calls classAttributeChanged() from StyledElement::parseMappedAttribute().
> Now classAttributeChanged() invokes dispatchSubtreeModifiedEvent() which internally calls invalidateCachesThatDependOnAttributes() to invalidate m_classNodeListCache.

I wasn't aware of this but that sounds wrong. I don't think we should be dispatching SubtreeModified when attributes change like that. Thanks for the clarification!

> Now we modified the code so that it will only invalidate the m_microDataItemListCache when itemType attribute changes, it should not send the dispatchSubtreeModifiedEvent() as you suggested.
> Do we need to follow the same as earlier case?

Probably not. I think your current approach is fine. We should probably fix other implementations not to fire SubtreeModified when attributes change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.