[Webkit-unassigned] [Bug 66878] HTMLAudioElement can be garbage collected while it playing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66878





--- Comment #22 from Eugene Nalimov <enal at google.com>  2011-10-11 14:58:52 PST ---
(1) Oops, code generator changes somehow not included into patch... Will resubmit shortly...

>Do we need to do this for every ActiveDOMObject?  Why doesn't the code generator >do this for us?

>> Source/WebCore/bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:78
>> -    V8DOMWrapper::setJSWrapperForDOMNode(audio.get(), v8::Persistent<v8::Object>::New(args.Holder()));
>> +    V8DOMWrapper::setJSWrapperForActiveDOMObject(audio.get(), v8::Persistent<v8::Object>::New(args.Holder()));

>Do we need to do this for every active dom object?  Should we check all the >constructors for active DOM objects?

(2) That is custom constructor, not generated one. If it was generated everything would be Ok.

>> LayoutTests/fast/xpath/xpath-result-eventlistener-crash.html:29
>> -    for (var i = 0; i < 5000; ++i)
>> +    for (var i = 0; i < 2000; ++i)

>This change seems unrelated.

(3) On my (slow) Mac test started to time out when running debug Chrome build, because event listener became slower. Reduced number of iterations.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.