[Webkit-unassigned] [Bug 69737] [Qt] GeolocationClient cleanups

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69737





--- Comment #5 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-10-11 14:47:53 PST ---
(From update of attachment 110560)
View in context: https://bugs.webkit.org/attachment.cgi?id=110560&action=review

> Source/WebKit/qt/WebCoreSupport/GeolocationClientQt.cpp:23
> - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Unrelated change, but ok

> Source/WebKit/qt/WebCoreSupport/GeolocationClientQt.cpp:40
> +#if QT_VERSION < 0x050000

Wasn't there a nicer way of writing this like

#if QT_VERSION < QT_VERSION_CHECK(5, 0, 0)

> Source/WebKit/qt/WebCoreSupport/GeolocationClientQt.h:83
> +#if QT_VERSION < 0x050000
>      QtMobility::QGeoPositionInfoSource* m_location;
> +#elif QT_VERSION >= 0x050000
> +    QGeoPositionInfoSource* m_location;
> +#endif

Wouldnt a "using namespace" be better when using old Qt?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.