[Webkit-unassigned] [Bug 69863] DFG JIT 32_64 - Switch to cdecl calling convention.

Tue Oct 11 14:20:52 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=69863

Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110570|review?                     |review+
               Flag|                            |

--- Comment #3 from Oliver Hunt <oliver at apple.com>  2011-10-11 14:20:52 PST ---
(From update of attachment 110570)
View in context: https://bugs.webkit.org/attachment.cgi?id=110570&action=review

r=me, fix the spelling error and the sizeof<SPACE!!!!>( style error

> Source/JavaScriptCore/ChangeLog:8
> +        This makes it easier to keep the stack correctly aligned, which is reuired on OS X.

required.

r-!!!!!111!!!1!!!111!1

> Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h:1060
> +        m_jit.move(Imm32(numConstants), GPRInfo::argumentGPR2);
> +        m_jit.move(Imm32(startConstant), GPRInfo::argumentGPR1);

well caught sir!

>> Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h:1252
>> +        m_jit.storeDouble(value, JITCompiler::Address(JITCompiler::stackPointerRegister, m_callArgumentIndex * sizeof (void*)));
> 
> Extra space before ( in function call  [whitespace/parens] [4]

This is a real style bug in the sizeof

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.