[Webkit-unassigned] [Bug 68853] Need a mechanism to query plugins for scaling to printable area or not.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68853





--- Comment #8 from Steve VanDeBogart <vandebo at chromium.org>  2011-10-11 13:00:43 PST ---
(From update of attachment 108775)
View in context: https://bugs.webkit.org/attachment.cgi?id=108775&action=review

>> Source/WebKit/chromium/public/WebFrame.h:451
>> +    // If the frame or node is a plugin whose content indicates that printed
> 
> What does it mean for a frame to be a plugin?  Are you referring to the case of
> a full-frame plugin, which has a PluginDocument?  Maybe say "If the frame contains
> a full-frame plugin or the given node refers to a plugin, and the plugin's content
> indicates that printed output..."

Done.

>> Source/WebKit/chromium/src/WebFrameImpl.cpp:1404
>> +    ASSERT(!frame()->document()->isFrameSet());
> 
> why do you have this assertion here?

Copied from printBegin(), removed.

>> Source/WebKit/chromium/src/WebFrameImpl.cpp:1412
>> +      return false;
> 
> nit: indentation

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.