[Webkit-unassigned] [Bug 68610] Microdata: Basic implementation of document.getItems() method

Tue Oct 11 12:06:46 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=68610

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org>  2011-10-11 12:06:46 PST ---
(In reply to comment #13)
> (From update of attachment 110347 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110347&action=review
> 
> > Source/WebCore/dom/MicroDataItemList.cpp:58
> > +    if (m_typeNames.contains("undefined") || !m_typeNames.size())
> 
> Are you trying to detect a case where the script didn't pass type? I don't think comparing it to the string 'undefined' is the right approach.

Sam, do you know a better way of doing this? We have a function that takes DOMString and we want to detect a case where the author omitted the argument.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.