[Webkit-unassigned] [Bug 69097] REGRESSION (r95381): Standalone video can be focused and draws a focus ring

Mon Oct 10 15:54:19 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=69097

--- Comment #16 from Eric Carlson <eric.carlson at apple.com>  2011-10-10 15:54:19 PST ---
(From update of attachment 110128)
View in context: https://bugs.webkit.org/attachment.cgi?id=110128&action=review

> LayoutTests/fast/events/media-focus-in-standalone-media-document.html:17
> +    var videoElement;
> +    var skipOnFirstEmptyLoad = 0;
> +    if (window.layoutTestController)
> +    {
> +         layoutTestController.dumpAsText();
> +         layoutTestController.waitUntilDone();
> +    }
> +
> +    function log(message)
> +    {
> +        document.getElementById("console").innerHTML += message + "<br>";
> +    }

If you include video-test.js much of this is unnecessary, plus the test output will look like the rest of the media layout tests.

> LayoutTests/fast/events/media-focus-in-standalone-media-document.html:48
> +        //Simulate click event to try focus video element.

Nit: missing a space after the "//"

> LayoutTests/fast/events/media-focus-in-standalone-media-document.html:67
> +</script>
> +</head>
> +<body>
> +<p>
> +This tests that  media element in a standalone media document cannot be focused directly using focus() method or by mouse click.
> +</p>
> +<p id="console"></p>
> +<iframe id="videoframe" width=380 height=330 onload="frameLoaded()"></iframe>
> +<script>
> +document.getElementById("videoframe").src = "../../media/" + findMediaFile("video", "content/test");
> +</script>
> +</body>
> +</html>

Indentation would make this much easier to read, IMO.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.