[Webkit-unassigned] [Bug 69435] remove WTF_CHANGES define, as it is always 1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 10 14:13:53 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=69435
Darin Adler <darin at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ggaren at apple.com,
| |msaboff at apple.com,
| |sam at webkit.org
--- Comment #6 from Darin Adler <darin at apple.com> 2011-10-10 14:13:52 PST ---
(In reply to comment #4)
> The define is poorly named, however
I agree.
> I wonder if it really needs to make it all the way out to JavaScriptCore/config.h.
I think it’s inconvenient that it’s there. It would be nice if it wasn’t.
> Also not all changes to tcmalloc are guarded by this flag.
Also a good point.
> Do you think that there is something worth doing here or should we close this bug?
I think it’s worth finding out if we are getting any value from having our changes wrapped in #if now. If we’re not, it might be nice to reduce the noise and complexity by removing this.
I think the real question is who would know the answer to that. Who has recently dealt with comparing with the “real” TCMalloc or importing a new version of it into our source tree? I cc’d a few people who might know.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list