[Webkit-unassigned] [Bug 69690] DFG does not have flow-sensitive intraprocedural control flow analysis

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 10 10:03:04 PDT 2011


--- Comment #25 from Gavin Barraclough <barraclough at apple.com>  2011-10-10 10:03:04 PST ---
(From update of attachment 110310)
View in context: https://bugs.webkit.org/attachment.cgi?id=110310&action=review

1/2 way through the review!

> Source/JavaScriptCore/bytecode/PredictedType.cpp:47
> +    bool isTop = true;

Could we not just test a mask & early return here?

> Source/JavaScriptCore/dfg/DFGAbstractState.cpp:34
> +namespace JSC { namespace DFG {

We normally only use ENABLE_* definitions in Platform.h (because this is included everywhere, and the way the macro works means a missed include won't result in a compile error).
It would be better to make this a regular define & #if FOO check.

> Source/JavaScriptCore/dfg/DFGAbstractState.cpp:63
> +    PROFILE(17);

Not a big issue, but it would probably be better to define these values rather than use magic numbers through the code.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list