[Webkit-unassigned] [Bug 69731] New: [GTK] Event listener callback return values are ignored

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69731

           Summary: [GTK] Event listener callback return values are
                    ignored
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P3
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bobert at lavitanuova.com


It is common in GTK for signal callbacks to return a gboolean value, which indicates one of:
- The callback has "completely handled" the signal, and it should not be propagated to other signal listeners at the same phase
- The callback has not completely handled the signal, and it should be propagated to other listeners at the same phase

Examples of WebKitGtk event listeners that are registered using webkit_dom_event_target_add_event_listener() follow this convention, e.g. in Epiphany.

However, in WebKitGtk 1.4.2, GObjectEventListener.cpp, GObjectEventListener::handleEvent(), callbacks are handled so their return value is ignored, and the event continues to propagate in all instances.

After some email discussion with Xan Lopez, we agree the best fix would be to change this to match normal GTK practice, and other DOM bindings, so the return value from the callback can stop the event propagation. I plan to submit a patch to implement this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.