[Webkit-unassigned] [Bug 69730] New: [GTK] Misnamed argument inverts semantics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69730

           Summary: [GTK] Misnamed argument inverts semantics
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P3
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bobert at lavitanuova.com


In WebKitGtk 1.4.2, WebKitDomNode.cpp, the function webkit_dom_node_add_event_listener() accepts a "bubble" argument, and passes it unchanged to WebCore::GObjectEventListener::addEventListener().

However, the implementation of addEventListener(), in GObjectEventListener.h, has a "useCapture" argument at that same position. And digging past that, it does appear that argument means whether to fire the handler during the capture phase.

Xan Lopez confirmed this, and suggested submitting a patch to make the parameter name consistent with what it actually accomplishes, which I will do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.