[Webkit-unassigned] [Bug 69702] JSVALUE32_64 DFG JIT - Bug fixes for Branch and LogicalNot

Sat Oct 8 12:36:06 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=69702

Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #110271|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |

--- Comment #2 from Filip Pizlo <fpizlo at apple.com>  2011-10-08 12:36:06 PST ---
(From update of attachment 110271)
View in context: https://bugs.webkit.org/attachment.cgi?id=110271&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:560
>      speculationCheck(m_jit.branch32(MacroAssembler::NotEqual, valueTagGPR, TrustedImm32(JSValue::UndefinedTag)));

It's sad that we need two branches here. :-(  But I think that we can optimize this later; more important is that your version is safer and more likely to be correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.