[Webkit-unassigned] [Bug 69669] WebKit2/Shared/APIClient.h complains that array subscript is below array bounds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 7 16:26:07 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69669





--- Comment #2 from Darin Adler <darin at apple.com>  2011-10-07 16:26:07 PST ---
(From update of attachment 110225)
View in context: https://bugs.webkit.org/attachment.cgi?id=110225&action=review

Could you be more specific about what the warning is? Maybe it’s fixable instead of something we need to turn off.

> Source/WebKit2/Shared/APIClient.h:40
> +#pragma GCC diagnostic ignored "-Warray-bounds"

I don’t think this is the best practice for using a compiler-specific pragma. In the past we have used #if around them.

> Source/WebKit2/Shared/APIClient.h:55
> +#pragma GCC diagnostic warning "-Warray-bounds"

It’s not good to unconditionally turn a warning on even if it wasn’t on before; instead you should use push/pop.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list