[Webkit-unassigned] [Bug 69295] Web Inspector: reimplement protocol backend/frontend source generator

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 7 12:08:42 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69295





--- Comment #24 from Ilya Tikhonovsky <loislo at chromium.org>  2011-10-07 12:08:41 PST ---
> > > Source/WebCore/inspector/CodeGeneratorInspector.py:449
> > > +${responseCook}sendResponse(callId, result, String::format("Some arguments of method '%s' can't be processed", "$domainName.$methodName"), protocolErrors, error);
> > It'd be nice to extract String::format("Some arguments of method '%s' can't be processed", "some method name") call to an inline function.
> 
> There's no need for formatting it on runtime. We should format it right in generator instead.
> 

In this case the size of binary will be bigger.


> > > Source/WebCore/inspector/CodeGeneratorInspector.py:601
> > > +$messageHandlers
> > wrong indent in the generated file.
> 
> This is a multi-line placeholder. Indents are inside argument.

I saw the wrong indent in the generated file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list