[Webkit-unassigned] [Bug 69022] Get rid of EditingText

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69022





--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org>  2011-10-07 10:06:31 PST ---
(In reply to comment #8)
> (In reply to comment #5)
> > Yeah, I thought we normally insert br in empty blocks but maybe br has zero-height? We just need to figure out other ways to make it work.
> 
> I had a look through the code and found that EditingText is used to create empty text nodes having renderer in InsertTextCommand, htmlediting (for tabSpan) and ReplaceCommandSelection . I could not find other way to make blank text node with renderer. We might have to just add a special case for Text node as i tried in previous patch or we might have to change the logic wherever EditingText is being used. Any guidelines/suggestions will be helpful.

I think the only reason we do that is to allow empty blocks editable but we can accomplish the same by inserting a br. Whether it's an empty text node or br isn't important as long as you can edit an empty block.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.