[Webkit-unassigned] [Bug 69343] [GTK] Initial implementation of back forward list for WebKit2 GTK+ API

Fri Oct 7 05:41:00 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=69343


--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-10-07 05:41:00 PST ---
(In reply to comment #5)
> > > No need for a cast here. Maybe this should happen in webkitWebBackForwardListItemCreate so that if we use it somewhere else we don't have to duplicate this?
> > 
> > Yes, the cast is needed, because wkItem is const. Moving it to 
> webkitWebBackForwardListItemCreate() we wouldn't need GetOrCreate().
> 
> You should use a C++ style cast in this cast const_cast<etc>(...). This brings up an interesting problem. The hash you have has a subtle bug. If the WK item is freed and another is reallocated in the same spot the cache will return the wrong item. You'll need to ensure that they are the same item when returning them, I think.

None of the C++ casts work here . . .

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.