[Webkit-unassigned] [Bug 69249] [GTK][WEBKIT2] Add webkit_web_view_load_html and webkit_web_view_load_plain_text APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69249





--- Comment #22 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-10-07 02:47:21 PST ---
(From update of attachment 109962)
View in context: https://bugs.webkit.org/attachment.cgi?id=109962&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:256
> + * @html: The HTML string to load

Use content instead of html for consistency with webkit_web_view_load_alternate_html.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:262
> + * The mime type of the document will be "text/html".
> + */

Please add:

 * You can monitor the status of the load operation using the
 * #WebKitWebLoaderClient of @web_view. See webkit_web_view_get_loader_client().

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:264
> +void webkit_web_view_load_html(WebKitWebView* webView, const gchar* html, const gchar* baseUri)
> +{

Use baseURI instead of baseUri.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:281
> + * Load the specified plain text string into @web_view. The mime type of
> + * document will be "text/plain".
> + */

Please add:

 * You can monitor the status of the load operation using the
 * #WebKitWebLoaderClient of @web_view. See webkit_web_view_get_loader_client().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.