[Webkit-unassigned] [Bug 69048] Separate compositor platform support from webkit's platform support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69048





--- Comment #18 from James Robinson <jamesr at chromium.org>  2011-10-06 18:44:43 PST ---
(From update of attachment 110074)
View in context: https://bugs.webkit.org/attachment.cgi?id=110074&action=review

I think a lot of our threading stuff will explode if the compositor's notion of the "main thread" and the "compositor thread" are actually the same thing - we do blocking calls from one to the other.

How are you ensuring that the compositor thread shuts down before the thread backing CompositorSupport?

> Source/WebCore/platform/graphics/chromium/cc/CCMainThread.cpp:45
> +    CompositorSupport::callOnMainThread(performTask, task.leakPtr());

hm, so you aren't using WTF::callOnMainThread() directly here any more?

If so you should update the comment in CCMainThread.h, remove the #include <wtf/MainThread.h> from this .cpp, and possibly go update CCLayerTreeHostTests to use your thread infrastructure instead of using webkit_support::'s main thread interaction functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.