[Webkit-unassigned] [Bug 13332] List marker not displayed on items with overflow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=13332





--- Comment #20 from Konstantin Shcheglov <scheglov at google.com>  2011-10-06 13:47:46 PST ---
(In reply to comment #18)
> (From update of attachment 109954 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109954&action=review
> 
> > Source/WebCore/rendering/RenderBox.cpp:1160
> > +    if (paintInfo.phase == PaintPhaseListMarkers)
> > +        for (RenderObject* child = firstChild(); child; child = child->nextSibling())
> > +            if (child->isListMarker())
> > +                return false;
> 
> I don't much like this code and am trying to think of a better approach.
> 
> The reason I am minusing though is that whatever test case led you to do this, you didn't patch the RenderLayer version. Find the test case that led you to add this code and then change the overflow:hidden object to also have position:relative. The RenderLayer clips will then be pushed, and since you only paint list markers during the time that the foreground clip is respected in RenderLayer, you'll still have a problem.

  Actually this code was added not because we don't paint markers, but because we paint too much of them.
  We should respect clip of _parent_ DIV, including layer.

  In case of RenderLayer we already have clip.
  As I see, RenderLayer uses clip from Renderer with overflow:hidden.
  So, I can not add any new test here.


> Even then, this doesn't seem good enough to me. What about a marker placed inside an overflow:hidden child div that also has a RenderLayer? I'm not even sure we propagate the overflow properly in this case.

  Yes, here we have problem.
  We paint when layer clip is already set.
  I've added test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.