[Webkit-unassigned] [Bug 69509] [GTK] Add estimated-progress property to WebKitWebLoaderClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69509





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-10-06 10:59:12 PST ---
(In reply to comment #3)
> (From update of attachment 109939 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109939&action=review
> 
> I think estimated-progress is fine. :)
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:259
> > +     * An estimate of the percent complete for a document load. This
> 
> complete->completion Maybe you should say "for the current loading operation." It includes subresources and subdocuments too, so maybe you shouldn't mention the document. Might want to explicitly say that it includes all subresources, actually.

It already mentions it:

* The value is an estimate based on the total number of bytes expected                                                                                                                  
* to be received for a document, including all it's possible subresources.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:264
> > +     * to be received for a document, including all it's possible subresources.
> 
> it's -> its

Ok.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:270
> > +                                                        "An estimate of the percent complete for a document load",
> 
> complete -> completion

Ok.

> > Source/WebKit2/UIProcess/API/gtk/tests/testloading.c:80
> > +    fixture->progress = 0.;
> 
> No need for the extra period here.

Ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.