[Webkit-unassigned] [Bug 69343] [GTK] Initial implementation of back forward list for WebKit2 GTK+ API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 6 09:39:51 PDT 2011


--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2011-10-06 09:39:51 PST ---
(In reply to comment #6)

> > You should use a C++ style cast in this cast const_cast<etc>(...). This brings up an interesting problem. The hash you have has a subtle bug. If the WK item is freed and another is reallocated in the same spot the cache will return the wrong item. You'll need to ensure that they are the same item when returning them, I think.
> I used the pointer because items are cached by WebProcess.

You'll still need to check that the item is the same in getOrCreate. Otherwise you might return the wrong cached GTK+ item for an particular WK item.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list