[Webkit-unassigned] [Bug 69506] [GTK] Do not use C API in GTK+ API public headers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69506


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109932|1                           |0
        is obsolete|                            |
 Attachment #109932|review-                     |review+
               Flag|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2011-10-06 09:17:53 PST ---
(From update of attachment 109932)
View in context: https://bugs.webkit.org/attachment.cgi?id=109932&action=review

Okay...I think I'm convinced.

> Source/WebKit2/UIProcess/API/gtk/WebKitDefines.h:45
> +#include <glib.h>
> +
> +#ifdef G_OS_WIN32
> +#    ifdef BUILDING_WEBKIT
> +#        define WEBKIT_API __declspec(dllexport)
> +#    else
> +#        define WEBKIT_API __declspec(dllimport)
> +#    endif
> +#    define WEBKIT_OBSOLETE_API WEBKIT_API
> +#else
> +#    define WEBKIT_API __attribute__((visibility("default")))
> +#    define WEBKIT_OBSOLETE_API WEBKIT_API __attribute__((deprecated))
> +#endif

You should not indent preprocessor defines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.