[Webkit-unassigned] [Bug 68434] [GTK] Implement cache model for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68434





--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-10-06 08:37:05 PST ---
(In reply to comment #11)
> (From update of attachment 109934 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109934&action=review
> 
> Looks good, but please handle the situation where sysconf returns an error before landing.
> 
> > Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp:46
> > +#else
> > +static uint64_t kDefaultMemorySize = 512;
> > +#endif
> 
> I would move this down to getMemorySize.

Ok.

> > Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp:68
> > +#if !OS(WINDOWS)
> > +    return ((sysconf(_SC_PAGESIZE) / 1024) * sysconf(_SC_PHYS_PAGES)) / 1024;
> > +#else
> > +    // Fallback to default for other platforms.
> 
> If any of these sysconf calls return -1 you need to return the default memory size.

Right! Btw, this patch depends on bug #69506, it uses WEBKIT_API instead of WK_EXPORT

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.