[Webkit-unassigned] [Bug 68434] [GTK] Implement cache model for WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 6 08:30:25 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=68434


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109934|review?                     |review+
               Flag|                            |




--- Comment #11 from Martin Robinson <mrobinson at webkit.org>  2011-10-06 08:30:25 PST ---
(From update of attachment 109934)
View in context: https://bugs.webkit.org/attachment.cgi?id=109934&action=review

Looks good, but please handle the situation where sysconf returns an error before landing.

> Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp:46
> +#else
> +static uint64_t kDefaultMemorySize = 512;
> +#endif

I would move this down to getMemorySize.

> Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp:68
> +#if !OS(WINDOWS)
> +    return ((sysconf(_SC_PAGESIZE) / 1024) * sysconf(_SC_PHYS_PAGES)) / 1024;
> +#else
> +    // Fallback to default for other platforms.

If any of these sysconf calls return -1 you need to return the default memory size.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list