[Webkit-unassigned] [Bug 69301] WebFileChooserParams needs a value to specify a "Save As" dialog.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69301


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109544|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-10-05 21:40:22 PST ---
(From update of attachment 109544)
View in context: https://bugs.webkit.org/attachment.cgi?id=109544&action=review

> Source/WebKit/chromium/public/WebFileChooserParams.h:47
> +    bool saving;

I struggle a bit with the wording here.  I considered suggesting "saveAs".  Then
at least you could say "saveAs" chooser, just as you can say "multiSelect" chooser
or "directory" chooser.  I'm not sure though.

I feel like the properties here should either describe the dialog or the resulting
file(s).  The other existing property names are not so great.

I can imagine something like {return,select,choose}{Multiple,Directory,Writable}
might be nice.  Those would very clearly describe the file(s) being returned.

Anyways, maybe that's just fodder for a future patch as changes like that would
be pretty out-of-scope for what you are trying to do now.

I think there are still some details to work out about what it means to return
a writable file as a result of presenting a "save as" dialog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.