[Webkit-unassigned] [Bug 69409] [GTK] [WebKit2] Make adding another unit test easier

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 5 20:12:20 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69409





--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2011-10-05 20:12:20 PST ---
Carlos, I examined your patch again and I think it is  not not so different from mine. I see a few main differences:

1. main() is inside a #define and depends on the fact that a test suite can only use one type of fixture. 
2. Tests are embedded in the fixtures.
3. The files use their original names.

Number 3 is not so important to me, but I do believe we should name the tests after the API they test - testloading -> testwebloaderclient, etc.

Number 1 and 2 are pretty important to me though. Fixtures should be independent of tests, we should be able to share them between suites and suites should be able to mix and match fixtures. That's the main reason I wanted to do this. Perhaps we can reach some sort of compromise on the rest?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list