[Webkit-unassigned] [Bug 69458] Fix memory leak with WebURLLoaderClient.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69458





--- Comment #5 from asvitkine at chromium.org  2011-10-05 13:55:18 PST ---
(In reply to comment #0)
> Fix memory leak with WebURLLoaderClient.

Sorry, I was submitting this on behalf of Roger without understanding the full context - this specific change doesn't fix the leak - it's a code cleanup item. I'll update the ChangeLog description in the patch momentarily.

(In reply to comment #4)
> (From update of attachment 109847 [details])
> can you explain why we need this?  since the destructor is protected, no one should be deleting a WebURLLoaderClient pointer.

The motivation for this is that WebURLLoaderClient is basically an interface with a bunch of virtual methods, so its destructor should also be virtual.

For example, one could make a derived class that implements the interface and deletes instances of itself through a WebURLLoaderClient pointer (which is legal since the destructor is protected), which wouldn't work correctly without this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.