[Webkit-unassigned] [Bug 69073] [EFL] Change one-letter parameter variable with WebKit coding Style.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 5 11:21:46 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69073





--- Comment #7 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-10-05 11:21:45 PST ---
(In reply to comment #6)
> (From update of attachment 109731 [details])
> > Source/WebKit/efl/ewk/ewk_frame.cpp:471
> > -Eina_Bool ewk_frame_text_search(const Evas_Object* o, const char* string, Eina_Bool case_sensitive, Eina_Bool forward, Eina_Bool wrap)
> > +Eina_Bool ewk_frame_text_search(const Evas_Object* ewkFrame, const char* string, Eina_Bool case_sensitive, Eina_Bool forward, Eina_Bool wrap)
> 
> Unrelated, but "string" is a bad name.

"string" should not be used at all. Sooner or later it will end up conflicting with std::string.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list