[Webkit-unassigned] [Bug 69435] remove WTF_CHANGES define, as it is always 1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 5 10:13:57 PDT 2011


--- Comment #4 from Andy Wingo <wingo at igalia.com>  2011-10-05 10:13:58 PST ---
(In reply to comment #3)
> (From update of attachment 109812 [details])
> We created this define to help us track the original version of TCMalloc. We should not remove it just because it’s always 1. If it has outlived its usefulness we could remove it, but that decision should be made by whoever is merging in new versions of TCMalloc.

Thank you for the review, Darin.  The define is poorly named, however, and I wonder if it really needs to make it all the way out to JavaScriptCore/config.h.  Also not all changes to tcmalloc are guarded by this flag.

Do you think that there is something worth doing here or should we close this bug?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list