[Webkit-unassigned] [Bug 69403] [WK2] [GTK] WebKitTestRunner crashes with heap corruption

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69403





--- Comment #3 from Alejandro G. Castro <alex at igalia.com>  2011-10-05 10:07:12 PST ---
(In reply to comment #2)
> (From update of attachment 109753 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109753&action=review
> 
> Would it be sufficient to simply add 
> #if defined (BUILDING_GTK__)
> #include "autotoolsconfig.h"
> #endif /* defined (BUILDING_GTK__) */
> 
> to the prefix header?
> 

Probably it would work, but I was trying to get the same structure we have in all the  other config.h files in the repository, with the autotoolsconfig.h before the Platform.h. And I thought it is a better option to have the WebKit2.h included in the files that requires it instead of adding it to all the compilations.

Actually I was wondering if we could even remove the Prefix.h and just have the config.h.

> I'm wondering if there is some way we can #error out if the includes are in the wrong order. What do you think?
> 

Never tried it, I can check it.

> > Tools/WebKitTestRunner/PixelDumpSupport.h:32
> > +#include <stdlib.h>
> 
> Hrm...why is this necessary?

Apparently it is needed for the size_t now that WebKit2.h is not included in every compilation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.