[Webkit-unassigned] [Bug 69266] REGRESSION (r84225): Virtual function called from Node::parentNode()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69266





--- Comment #9 from Dominic Cooney <dominicc at chromium.org>  2011-10-04 21:06:35 PST ---
Another awkward difference between ShadowRoot and SVGShadowRoot is ShadowRoot sets and clears the flag when it goes into and out of the tree, but isSVGShadowRoot is constant.

A big hacky, but parentNode can be trivially sped up in the non-SVG case with something like:

return getFlag(IsShadowRootFlag) || (isSVGElement() && isSVGShadowRoot()) ? 0 : parent();

which predicates the virtual call on another flag test.

For now I am going to look at using these pairs of flags:

IsShadowRootFlag, not IsSVGElementFlag => ShadowRoot
IsShadowRootFlag, IsSVGElementFlag => SVGShadowRoot

I will rename the schizoflag to IsShadowRootOrSVGShadowRootFlag.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.