[Webkit-unassigned] [Bug 69073] [EFL] Change one-letter parameter variable with WebKit coding Style.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 4 19:23:36 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69073


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109731|                            |commit-queue-
               Flag|                            |




--- Comment #5 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-10-04 19:23:35 PST ---
Created an attachment (id=109731)
 --> (https://bugs.webkit.org/attachment.cgi?id=109731&action=review)
Prototype

I make a prototype patch for this bug. Major Changes are as below,

  1. Use ewkFrame instead of o in ewk_frame.cpp
  2. Use ewkView instead of o in ewk_view.cpp
  3. Use menu and item instead of o in ewk_contextmenu.cpp
  4. Use ewkTile instead of o in ewk_tile_xxx.cpp
  5. Use tile parameter name instead of t parameter in ewk_tile_xxx.cpp
  6. Run demarchi's script for ewk_tile_xxx.cpp files.
  7. Remove *void* parameter in ewk_tile_xxx.cpp's internal functions.

I think we have to change r, w and h with rect, width and height. But, I don't change them all in this prototype patch yet. If you guys agree with this changes, I will change them as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list