[Webkit-unassigned] [Bug 69220] Fix FrameView::scrollElementToRect to take already scrolled amount into consideration

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 4 17:33:52 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=69220


sadrul at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109717|0                           |1
        is obsolete|                            |
 Attachment #109723|                            |review?, commit-queue?
               Flag|                            |




--- Comment #13 from sadrul at chromium.org  2011-10-04 17:33:51 PST ---
Created an attachment (id=109723)
 --> (https://bugs.webkit.org/attachment.cgi?id=109723&action=review)
setScrollPosition

ScrollView::scrollTo has a NOTE saying it should only be called by the overriden setScrollOffset from ScrollableArea, and FrameView::scrollToAnchor has a comment saying it can trigger setScrollPosition. So I have changed here to use setScrollPosition instead of scrollTo/scrollBy. Does this look OK?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list