[Webkit-unassigned] [Bug 69107] Webkit API for compositor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69107





--- Comment #10 from Antoine Labour <piman at chromium.org>  2011-10-04 17:11:45 PST ---
(In reply to comment #6)
> (From update of attachment 109368 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109368&action=review
> 
> > Source/WebKit/chromium/public/WebContentLayer.h:37
> > +namespace WebCore { class ContentLayerChromium; }
> 
> you shouldn't leak any WebCore things in the header. does this just need to be in a #if WEBKIT_IMPLEMENTATION guard?
> 
> > Source/WebKit/chromium/public/WebContentLayer.h:49
> > +    ~WebContentLayer() { }
> 
> virtual

Done.

> 
> > Source/WebKit/chromium/public/WebLayer.h:37
> > +namespace WebCore { class LayerChromium; }
> 
> shouldn't this be inside a WEBKIT_IMPLEMENTATION guard? we shouldn't leak webcore types through this header

So, it is needed so that the header compiles outside of WebKit. The type needs to be forward-declared so that m_private can be declared, even outside of WebKit.

> 
> > Source/WebKit/chromium/public/WebLayer.h:50
> > +    ~WebLayer() { reset(); }
> 
> if you wanna let people destroy WebLayers via a WebLayer*, virtual on this please

Done.

> 
> > Source/WebKit/chromium/public/WebLayerDelegate.h:16
> > + *     * Redistributions of source code must retain the above copyright
> > + * notice, this list of conditions and the following disclaimer.
> > + *     * Redistributions in binary form must reproduce the above
> > + * copyright notice, this list of conditions and the following disclaimer
> > + * in the documentation and/or other materials provided with the
> > + * distribution.
> > + *     * Neither the name of Google Inc. nor the names of its
> > + * contributors may be used to endorse or promote products derived from
> > + * this software without specific prior written permission.
> 
> here and other files: we use a 2-clause license header for new code

Done.

> 
> > Source/WebKit/chromium/src/WebContentLayer.cpp:5
> > + * copyright (c) 2011 google inc. all rights reserved.
> > + *
> > + * redistribution and use in source and binary forms, with or without
> > + * modification, are permitted provided that the following conditions are
> 
> somehow bizarrely this license header became totally lowercase

Done (typo 'u' in vim).

I also renamed WebLayerTreeHost* to WebLayerTreeView*

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.