[Webkit-unassigned] [Bug 61344] --webkit-visual-word does not work in multi-line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61344


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107738|review?                     |review-
               Flag|                            |




--- Comment #31 from Ryosuke Niwa <rniwa at webkit.org>  2011-10-04 14:46:37 PST ---
(From update of attachment 107738)
View in context: https://bugs.webkit.org/attachment.cgi?id=107738&action=review

> Source/WebCore/ChangeLog:10
> +        DOM node.

Nit: it seems like DOM node fits in the previous line.

> Source/WebCore/editing/visible_units.cpp:1485
> +        Position pos;
> +        pos = createLegacyEditingPosition(previousNode, caretMaxOffset(previousNode));

Nit: this should be don in one line.

> Source/WebCore/editing/visible_units.cpp:1487
> +        if (pos.isCandidate()) {

Why do we need to check that this is a candidate?

> Source/WebCore/editing/visible_units.cpp:1493
> +            InlineBox* boxInPreviousNode;
> +            int ignoredCaretOffset;
> +            pos.getInlineBoxAndOffset(DOWNSTREAM, boxInPreviousNode, ignoredCaretOffset);
> +
> +            if (boxInPreviousNode)
> +                return boxInPreviousNode->root();

Please use RenderedPosition.

> Source/WebCore/editing/visible_units.cpp:1539
> +                                                          nextRootInlineBox(box); 

Nit: wrong indentation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.