[Webkit-unassigned] [Bug 66878] HTMLAudioElement can be garbage collected while it playing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66878





--- Comment #6 from Adam Barth <abarth at webkit.org>  2011-10-04 10:18:02 PST ---
(From update of attachment 108865)
View in context: https://bugs.webkit.org/attachment.cgi?id=108865&action=review

> Source/WebCore/ChangeLog:8
> +        Playing HTMLAudioElement can be garbage collected
> +        https://bugs.webkit.org/show_bug.cgi?id=66878
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Test: media/audio-garbage-collect.html

This ChangeLog isn't really helping me understand why you're making this change.  :(

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1167
> +    elsif ($implClassName eq "Node") {
> +        push(@implContentDecls, <<END);
> +        args.Holder()->${hiddenValueAction}HiddenValue(v8::String::Concat(v8::String::New(\"listener/\"),args[0]->ToString())${hiddenValueExtraArgs});

I don't really understand what this part of the change is doing.  Also, why is Node a special case?

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2843
>      return 1 if $type eq "IDBTransaction";
>      return 1 if $type eq "FileReader";
>      return 1 if $type eq "FileWriter";
> +    return 1 if $type eq "HTMLAudioElement";

We shouldn't have this list in the code generator!!!  We should get this information from the IDL files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.