[Webkit-unassigned] [Bug 69338] Fails to build when sqlite is not in /usr/include

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69338


Leandro Pereira <leandro at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109622|review?                     |review-
               Flag|                            |




--- Comment #2 from Leandro Pereira <leandro at profusion.mobi>  2011-10-04 08:09:45 PST ---
(From update of attachment 109622)
View in context: https://bugs.webkit.org/attachment.cgi?id=109622&action=review

Informal r-.

> Source/WebCore/CMakeListsEfl.txt:243
> -  ${ICU_INCLUDE_DIRS}
> +  ${ICU_INCLUDE_DIR}

FindICU actually sets ICU_INCLUDE_DIRS.

> Source/WebCore/CMakeListsEfl.txt:246
> -  ${LIBXSLT_INCLUDE_DIRS}
> -  ${SQLITE_INCLUDE_DIRS}
> +  ${LIBXSLT_INCLUDE_DIR}
> +  ${SQLITE_INCLUDE_DIR}

This looks fine; however, please mention xslt as well in the ChangeLog entry.

> Source/WebCore/ChangeLog:1
> +2011-10-04  Rémi Duraffort  <remi.duraffort at st.com>

I'll assume this encoding error is Bugzilla's fault.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.