[Webkit-unassigned] [Bug 69321] New: JITCodeGenerator should no longer have code that tries too hard to be both speculative and non-speculative

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69321

           Summary: JITCodeGenerator should no longer have code that tries
                    too hard to be both speculative and non-speculative
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: fpizlo at apple.com


JITCodeGenerator used to be a superclass for NonSpeculativeJIT and SpeculativeJIT.  Now the NonSpeculativeJIT is gone.  There are some warts from this:

- JITCodeGenerator has a m_isSpeculative field.  This field is now always true.

- JITCodeGenerator has a method to emit a speculation check, if we're in speculative mode.  Code that needs speculation checks should probably just be moved to SpeculativeJIT.

- JITCodeGenerator has an emitBranch method that tries to unify both speculative and non-speculative handling of branches.  Now it should probably just be speculative.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.