[Webkit-unassigned] [Bug 69197] First round of unit tests for CCLayerTreeHostCommon

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 3 16:38:47 PDT 2011


--- Comment #2 from Vangelis Kokkevis <vangelis at chromium.org>  2011-10-03 16:38:47 PST ---
(From update of attachment 109383)
View in context: https://bugs.webkit.org/attachment.cgi?id=109383&action=review

Looks good!  Thanks for getting the ball rolling on this.

> Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp:95
> +void executeCalculateDrawTransformsAndVisibilityWithDummyVariables(LayerChromium * rootLayer)

nit: Shortening the name of this function (e.g. getting rid of the WithDummyVariables part) will make the rest of the code somewhat easier to read.

> Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp:354
> +TEST(CCLayerTreeHostCommonTest, verifyTransformsForRenderSurfaceHierarchy)

Since this test doesn't test anything, it should be removed.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list