[Webkit-unassigned] [Bug 68460] Add WebCore platform interfaces needed by updated MediaStream and PeerConnection design

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68460





--- Comment #26 from Adam Barth <abarth at webkit.org>  2011-10-03 13:07:43 PST ---
> Our idea has been to have separate implementations of the PeerHandlerPrivate interface and select one at compile time as you describe.
> 
> #if PLATFORM(CHROMIUM)
> #include "PeerHandlerPrivateChromium.h"
> #define PeerHandlerPrivateClassName PeerHandlerPrivateChromium
> #elif USE(GSTREAMER)
> ...

That's not the usual way we do that sort of thing in WebKit.  It's probably better follow the model used, for example, by ResourceHandle.  In that approach, there is a shared h file and separate cpp files that different ports can link in.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.