[Webkit-unassigned] [Bug 68460] Add WebCore platform interfaces needed by updated MediaStream and PeerConnection design

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68460





--- Comment #25 from Adam Bergkvist <adam.bergkvist at ericsson.com>  2011-10-03 12:59:52 PST ---
(In reply to comment #24)
> Sorry for the delay in replying Adam.  I've talked the issue over with Tommy, and he agrees that the API you propose in Comment #23 should work for Chromium as well.
>
> My sense we'll want to be able to choose different implementations of that API at compile time.  For example, we'll likely have an implementation using Tommy's high-level library and an (larger) implementation using Gstreamer.
>

Our idea has been to have separate implementations of the PeerHandlerPrivate interface and select one at compile time as you describe.

#if PLATFORM(CHROMIUM)
#include "PeerHandlerPrivateChromium.h"
#define PeerHandlerPrivateClassName PeerHandlerPrivateChromium
#elif USE(GSTREAMER)
...

The code above would be at line 40 in PeerHandler.cpp, but is omitted in this patch since there are no implementations available yet.

> Maybe a good first step is to check in the header files for the Platform API?  Then we can proceed to add the callers and the implementations of the API in parallel.

Yes, that seems like a good starting point. I've created bugs 68462 and 68464 to add the caller code in PeerConnection and MediaStream respectivly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.